Fix model-downloader and tgi in multi shard case #642
Merged
+75
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianhao
changed the title
eero-t
reviewed
Dec 12, 2024
eero-t
reviewed
Dec 13, 2024
eero-t
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Approved.
Cache being in emptyDir i.e. going away when the pod instance goes away (instead of being shared like model data), is more secure, but it can be significant pod startup performance issue. Especially with HPA and in other setups were pods come and go. That can be looked in another PR though.
I think in long term it would be better to separate model downloading and running of the application services. That would allow model downloading to be centralized to single service / container, instead of split over multiple pods, and even to do it as separate step before starting any of the application pods.
yongfengdu
approved these changes
Dec 17, 2024
Ruoyu-y
reviewed
Dec 17, 2024
Signed-off-by: Lianhao Lu <[email protected]>
Fix issue opea-project#639 Signed-off-by: Lianhao Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade huggingface-hub to version 0.26.5 when downloading models, due to the existing
huggingface/downloader:0.17.3image doesn't acknowledge the HF_TOKEN correctly.Loose the tgi securityContext to allow running with multi shard.
Issues
Fixes #641
Fixes #639
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.